shanecbell  Premium Established 156 points (20% positive, 80% negative)
registered 18.04.08

I am all about some D7!

 
 
All
Feedback
Newest
·Top
|
All
|
All
Please login to post a comment.
csampson1
I love this mod it's a great idea and will give me a great deal of flexibility to offer deals... Thanks for the great support and a great idea...
pethol
So - in essence - It's not really "free"...
shanecbell
The membership to the site will cost you and the template is FREE. So yes, it is FREE. If you would like to purchase the template it is $50. Let me know, thanks.
houstonlively
This is just plain old advertising SPAM.
shanecbell
Who are you and why do you say this? We have a template here that has been purchased already a couple of times and is not spam at all. Thanks for your keen insight however.
UFO360
Hello Shanecbell,

can we see all the templates demo before people paid for the annual membership
shanecbell
I am not quite sure what your statement means. Skype me at genesisgraphix to discuss please.
AndreyP
Package\templates\tmpl_uni\css\adwords_mod.css
crazy styles here, try to make it pretty (fix all spaces with tabs)
Now here or no tabs, or 2 spaces or tab.
Very wild style :)

Next,
Package\adsense_mod\ASMconfig.php and
Package\adsense_mod\ASMdisplay.php
naming convention is not met
look,
$s1 =
Ooh, recheck
http://www.boonex.com/unity/txt/extension_convention
again
2. Variable Declarations: Names
here clean sample how you should named variables

Next, please keep spacing between see more lines where need, keep your code clean and easy to read.

Next,
recheck formatting
again read code convention please,
I mean { } symbols
keep it at different lines

Next
Package\admin\adsense_mod\AdSenseModAdmin.php
much better than all previous files, but still same errors here

you can check good styles of developing just in sources of dolphin/orca
you can check also msdn.com site ;-)
shanecbell
That would mean that I am a dumb ass. Thanks. I have uploaded the correct version. Thank you! Please review as soon as you are able and let me know if I have made the cut.
AntonL
Looks like the problem with hard coded access is still there

define('DB_HOST','localhost');
define('DB_NAME','lifeisno_Boonex');
define('DB_USER','lifeisno_isog');
define('DB_PASS','97138');

May be you forget to upload the updated package.
shanecbell
That would mean that I am a dumb ass. Thanks. I have uploaded the correct version. Thank you! Please review as soon as you are able and let me know if I have made the cut.
shanecbell
The Version: 1.6.0000 file that was re-uploaded after your request uses the code below to load the settings off the header.inc.php file:

require_once( '../inc/header.inc.php' );
define('DB_HOST',$db['host']);
define('DB_NAME',$db['db']);
define('DB_USER',$db['user']);
define('DB_PASS',$db['passwd']);
if (!mysql_connect(DB_HOST, DB_USER, DB_PASS)) die('Error connecting to mysql database. Check mysql db access information ...');
if (!mysql_select_db(DB_NAME)) die('Error connecting to mysql see more database. Check mysql db name ...');
$mysql = mysql_query("SELECT * FROM `AdSenseMod_settings`");
while ($info = @mysql_fetch_array($mysql)) { @define($info['setting_id'],$info['value']); }
if (COMPONENT_ONOFF != '1') die("This component is disabled.");

And the v1.6.0 file is the same one available for download on the updated zip file attached to this extension entry.
AlexT
Some conventions is not met (as I mentioned above!)
Also you have the following hardcoded config:

define('DB_HOST','localhost');
define('DB_NAME','lifeisno_Boonex');
define('DB_USER','lifeisno_isog');
define('DB_PASS','97138');
shanecbell
That would mean that I am a dumb ass. Thanks. I have uploaded the correct version. Thank you! Please review as soon as you are able and let me know if I have made the cut.
shanecbell
I guess I don't follow:

require_once( '../inc/header.inc.php' );
define('DB_HOST',$db['host']);
define('DB_NAME',$db['db']);
define('DB_USER',$db['user']);
define('DB_PASS',$db['passwd']);
if (!mysql_connect(DB_HOST, DB_USER, DB_PASS)) die('Error connecting to mysql database. Check mysql db access information ...');
if (!mysql_select_db(DB_NAME)) die('Error connecting to mysql database. Check mysql db name ...');
$mysql = mysql_query("SELECT * FROM `AdSenseMod_settings`");
while see more ($info = @mysql_fetch_array($mysql)) { @define($info['setting_id'],$info['value']); }
if (COMPONENT_ONOFF != '1') die("This component is disabled.");


Where is the hard code as the $db['keywords'] variable import the boonex config into the adsense mod which bypassing hardcoding anything

Please explain for me, I am sure I am missing something. Thanks
AlexL
Hard-coding in AWMconfig.php still exists. You should get the configuration data from Dolphin inc/header.inc.php file.
shanecbell
I guess I don't follow:

require_once( '../inc/header.inc.php' );
define('DB_HOST',$db['host']);
define('DB_NAME',$db['db']);
define('DB_USER',$db['user']);
define('DB_PASS',$db['passwd']);
if (!mysql_connect(DB_HOST, DB_USER, DB_PASS)) die('Error connecting to mysql database. Check mysql db access information ...');
if (!mysql_select_db(DB_NAME)) die('Error connecting to mysql database. Check mysql db name ...');
$mysql = mysql_query("SELECT * FROM `AdSenseMod_settings`");
while see more ($info = @mysql_fetch_array($mysql)) { @define($info['setting_id'],$info['value']); }
if (COMPONENT_ONOFF != '1') die("This component is disabled.");


Where is the hard code as the $db['keywords'] variable import the boonex config into the adsense mod which bypassing hardcoding anything

Please explain for me, I am sure I am missing something. Thanks
shanecbell
Alex,

We have done the specified changes, and updated the name of the mod.
AlexT
naming convention is not met
place your files to separate directory
add instructions how to move css file if user have not uni template
get rig of hadcoded config in AWMconfig.php
 
 
PET:0.17641377449036